LOndon 10-Anu Thapaliya-HTML-CSS-Coursework-week1#317
LOndon 10-Anu Thapaliya-HTML-CSS-Coursework-week1#317anuthapaliy wants to merge 3 commits intoCodeYourFuture:masterfrom
Conversation
remaining last 2 stpes to complete.
SallyMcGrath
left a comment
There was a problem hiding this comment.
Thanks for this @anuthapaliy . I really appreciate the time and effort you've put into this. I've left a few comments and asked a few questions. Have a think about them. If you'd like to make changes, you can push those changes to this PR and it will update.
Great work! Thanks! ⭐
| @@ -0,0 +1,22 @@ | |||
| { | |||
There was a problem hiding this comment.
Hi @anuthapaliy
I think you've committed a file by mistake. Don't use git add .. Add each file one by one and on purpose, so this doesn't happen for you.
| */ | ||
| body | ||
| { | ||
| Color: blue; |
There was a problem hiding this comment.
I don't think this meets the style guide, do you? 🤔
The reason I think this is our style guide asks you to install Prettier and Prettier automatically formats your code.
| <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> | ||
|
|
||
| <body> | ||
| <h1>Social Media </h1> |
There was a problem hiding this comment.
Is there a sectioning element you could use to group this h1 and p tag? What is the purpose of grouping content with semantic html?
| </article> | ||
|
|
||
| <article class="instagram"> | ||
| <h3>Instagram</h3> |
There was a problem hiding this comment.
Do you think that Instagram and Youtube should be on the same level as Facebook? It seems like there are three blocks the same with different text content on this page. What do you think?
| <a href="https://www.britannica.com/topic/YouTube">Read More</a> | ||
| </article> | ||
| <footer> | ||
| Contact-: Anu Thapaliya |
There was a problem hiding this comment.
Is there a way you could mark up your name as an email?
| font-family: Impact, Haettenschweiler, 'Arial Narrow Bold', sans-serif; | ||
| font-size: medium; | ||
| } | ||
| .facebook{ |
There was a problem hiding this comment.
Can you think of a way to make a general class that controls the layout for all the articles on this page?
What does .class mean? How is it different from #id ?
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?