London10-Afsha Hossain-HTML/CSS - Week 1#332
London10-Afsha Hossain-HTML/CSS - Week 1#332Afsha10 wants to merge 1 commit intoCodeYourFuture:masterfrom
Conversation
| .menu { | ||
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: center; | ||
| } |
There was a problem hiding this comment.
this is great. It is best practise using the class
| button { | ||
| padding: 1rem 1rem; | ||
| margin: 1rem; | ||
| font-size: 20px; | ||
| border-radius: 10px; | ||
| } | ||
|
|
||
| main { | ||
| padding: 2rem; | ||
| } | ||
|
|
||
| article { | ||
| margin: 5rem 0; | ||
| } | ||
|
|
||
|
|
||
| article:first-child { | ||
| font-size: larger; | ||
| color: darkblue; | ||
| } | ||
|
|
||
| footer { | ||
| text-align: center; | ||
| } |
There was a problem hiding this comment.
The styles are good. Maybe try and do it with the css class like you did on line 32
| <main> | ||
| <article> | ||
| <h2>Experiencing Peace and Joy</h2> | ||
| <img src="http://data.freehdw.com/bridge-over-the-green-river.jpg" alt="Lake reflecting green trees surronding the lake. There is a long wooden bridge over the lake"> |
There was a problem hiding this comment.
can we download the image and link to it with a relative path <img src="proxy.php?url=https%3A%2F%2Fgithub.com%2Fimages%2Fpicture.jpg">
| </article> | ||
| <article> | ||
| <h2>Experiencing Peace</h2> | ||
| <img src="http://images.freehdw.com/800/nature-landscapes_other_wooden-house-in-forest_3295.jpg" alt="Small house in a forest. Morning sunrays falling over the trees and top of the house." |
There was a problem hiding this comment.
can we download the image and link to it with a relative path <img src="proxy.php?url=https%3A%2F%2Fgithub.com%2Fimages%2Fpicture.jpg">
| <!-- Add your HTML markup here --> | ||
| <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> |
There was a problem hiding this comment.
Can we delete these lines that are comments
|
|
||
| </article> | ||
| </main> | ||
| <footer>© 2023 Created with 💚 by Afsha</footer> |
There was a problem hiding this comment.
Can we use a html entity, see https://www.w3schools.com/html/html_entities.asp
©
| <body> | ||
| <header> | ||
| <nav> | ||
| <h1>Peace and Joy</h1> |
… page
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?