NorthWest_4 - Dharma_Guadeloupe - JavaScript_Core_1_Coursework - Week_1 by dharmaguadeloupe · Pull Request #111 · CodeYourFuture/JavaScript-Core-1-Coursework-Week1

dharmaguadeloupe · 2021-06-22T16:28:05Z

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

Your Name: Dharma Guadeloupe
Your City: NorthWest 4
Your Slack Name: Dharma

Homework Details

Module: JavaScript Module 1
Week: 1

Notes

What did you find easy? The exercises were great way to cement what I already knew
What did you find hard? Figuring out the ternary operator for the extra homework
What do you still not understand? Still a litle fuzzy on ternary's
Any other notes?

View rendered README.md
View rendered exercises/G-numbers/README.md

anthonytranDev

Nice work Dharma!

Some comments for you below

anthonytranDev · 2021-07-05T19:55:12Z

@@ -0,0 +1,3 @@
+{
+  "editor.formatOnSave": true


Instructions Followed Incomplete (optional)

Instructions have mentioned the following Set editor.formatOnSave and editor.formatOnPaste to true

This is optional as I usually turn the latter settings off

anthonytranDev · 2021-07-05T20:01:42Z

@@ -1,2 +1,9 @@
 var numberOfStudents = 15;


Incorrect Amount (Optional)

Isn't the correct amount of students and mentors, in your NW4 group - though will let you off. Most importantly, the core implementation is correct

anthonytranDev · 2021-07-05T20:04:39Z

-function multiply() {
+function multiply(num1, num2) {
  // Calculate the result of the function and return it
+  return num1 / num2;


Incorrect operator

Needs a multiplication operator - i.e. not a division operator

oops, honest mistake. That's what I get for not reading it properly. Fixed Now. Thanks

anthonytranDev · 2021-07-05T20:15:02Z


 /* BETTER PRACTICE */
-
-let goodCode =


Ignore this exercise - there is little guidance here and both are bad practice, as you aren't making the code more readable or succinct

Answer below

// don't use somewhat useless functions, when operators do a better job (and are more readable) const startingValue = 2 const bestCode = `${(10 + startingValue) * 2}`

anthonytranDev · 2021-07-05T20:15:25Z

-    Outlook not so good.
-    Very doubtful.
-*/
+  **/


Do less work 👍

anthonytranDev · 2021-07-05T20:21:08Z

+  return answerIteration < 5 ? "very positive" : answerIteration >=5 && answerIteration < 10 ? "positive"
+  : answerIteration >=10 && answerIteration < 15 ? "negative" : "very negative";


Style

Please Never use nested ternary statements, ever

For the following multiplicity logic - not a real term, just a way I describe it.
Only use ternary for single branched out logic

For the code here, stick to using the following:

Increase in (reading) complexity the way down

(A bunch of) if statements

Then, switch statements (or objects - key value pairs, if you know how to use them)

Lastly, if...else statements

This was setting myself the challenge of seeing if I could convert it and understand nested ternary statements. Below is the code I used to work it out using If /else logic

anthonytranDev · 2021-07-05T20:24:58Z

+/**if(answerIteration < 5) {
+  return "very positive";
+} else if(answerIteration >= 5 && answerIteration < 10) {
+  return "positive";
+} else if(answerIteration >=10 && answerIteration < 15) {
+  return "negative"
+} else {
+  return "very negative";
+}**/
+


Reducing complexity

This is actually more readable, you can try use a bunch of if statements

Oh avoid multiple return for if or if...else statements, try to assign the values, so that code flow can be read more linearly - it's more a special JavaScript style

Hint:

let message; if(answerIteration < 5 ) { message = "very positive"; } if(answerIteration >= 5 && answerIteration < 10 ) { message = "positive"; } // etc ... return message;

That's something I've learned since, I was writing a lot of extra code that isn't actually needed. It's great to come back to this so many weeks later and see the difference between this, and how I write code now.

anthonytranDev · 2021-07-05T20:26:37Z

  }

-  let seenPositivities = new Set(Array.from(answers.values()).map(checkAnswer));
+  let seenPositivities = new Set(Array.from(seenAnswers.values()).map(checkAnswer));


Arghhh...

Not your code, but I hate it. No one uses new Set in the industry, this isn't super easy to read either

That worried for a minute as I was certain I hadn't written this

anthonytranDev · 2021-07-05T20:28:28Z

  // Write the body of this function to concatenate three words together.
  // Look at the test case below to understand what this function is expected to return.
+  return firstWord.concat(' ', secondWord, ' ', thirdWord);
+


Style

Remove unnecessary newline

I'm not sure what means

anthonytranDev · 2021-07-05T20:29:05Z

+  const formattedCurrency = taxCalculation + product;
+  const salesTaxFormatted = formattedCurrency.toFixed(2);
+  return `£${salesTaxFormatted}`;
+


Style

Same here with removing the newline

github-actions · 2021-08-17T01:48:56Z

Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback.

DharmaKarmaStar added 29 commits June 20, 2021 11:56

run hello world exercise 1

9ec1863

Experiment part 1

c305728

Console logged several things at once

db9c8e2

Sees it as args

d7890f7

Sees its as a number not a string

7f6a000

C-variables added a variable to greeting

a459679

used a while loop to print to the log 3 times

52f7c5f

D-strings exercise with own message

d0e7429

concatenating strings exercise

4abb32f

F strings methods exercise 1

aeba26b

F-strings methods exercise 2

bba1a4e

G-numbers exercise

d039d8a

i_floats using math.round on exercise

3bffc43

functions exercise 1

7923fc5

functions exercise 2

3fa326e

K functions-parameters exercise1

d8173ef

functions params exercise2

33e361b

functions params exercise 3

1d63fe3

functions params exercise4

ce4700a

functions params exercise5

61039d9

functions nested exercise

4702f64

mandatory test suite1 fixed

ca0b7e1

test suite 2 fixed

e9b3a51

test suite 3 fixed

c8235ad

test suite 4 fixed and passed

cd5424c

Extra Test suite exercise 1

aa8c40f

Currency conversion tested

f9c49af

Piping exercise completed

390b7c2

magic 8-ball test completed

86adb34

anthonytranDev reviewed Jul 5, 2021

View reviewed changes

github-actions bot added the Stale label Aug 17, 2021

github-actions bot closed this Aug 17, 2021

		return answerIteration < 5 ? "very positive" : answerIteration >=5 && answerIteration < 10 ? "positive"
		: answerIteration >=10 && answerIteration < 15 ? "negative" : "very negative";

Uh oh!

Conversation

dharmaguadeloupe commented Jun 22, 2021 • edited by markdownify bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Your Details

Homework Details

Notes

Uh oh!

anthonytranDev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dharmaguadeloupe commented Jun 22, 2021 •

edited by markdownify bot

Loading