This repository was archived by the owner on Jan 14, 2024. It is now read-only.
describe tests in README; use jest projects#169
Merged
SallyMcGrath merged 3 commits intomasterfrom Sep 6, 2021
Merged
Conversation
40thieves
approved these changes
Jul 17, 2021
Contributor
40thieves
left a comment
There was a problem hiding this comment.
Some suggestions, otherwise looking good 🙂
Comment on lines
+23
to
+27
| Try out variant way of running tests: | ||
|
|
||
| - `npm test` -> run all mandatory and extra tests | ||
| - `npm test -- --selectProjects mandatory` -> run only mandatory tests | ||
| - `npm test -- --testPathPattern mandatory/1-syntax-errors.js` -> run single test |
Contributor
There was a problem hiding this comment.
This feels repetitive with the section above, what is it adding?
| - To run the tests for all mandatory/extra exercises, run `npm test` | ||
| - To run only the tests for the mandatory exercises, run `npm test -- --selectProjects mandatory` | ||
| - To run only the tests for the extra exercises, run `npm test -- --selectProjects extra` | ||
| - To run a single exercise/test (for example `mandatory/1-writer.js`), run `npm test -- --testPathPattern mandatory/1-writer.js` (Remember, you can use tab-completion to get files relative to the current directory, so m`Tab ↹`/1-`Tab ↹` will autocomplete get you the test file starting with 1-) |
Contributor
There was a problem hiding this comment.
What do you think about using <kbd>? Perhaps a bit overly clever?
Suggested change
| - To run a single exercise/test (for example `mandatory/1-writer.js`), run `npm test -- --testPathPattern mandatory/1-writer.js` (Remember, you can use tab-completion to get files relative to the current directory, so m`Tab ↹`/1-`Tab ↹` will autocomplete get you the test file starting with 1-) | |
| - To run a single exercise/test (for example `mandatory/1-writer.js`), run `npm test -- --testPathPattern mandatory/1-writer.js` (Remember, you can use tab-completion to get files relative to the current directory, so <kbd>m</kbd><kbd>Tab ↹</kbd>/<kbd>1-</kbd><kbd>Tab ↹</kbd> will autocomplete get you the test file starting with 1-) |
That would render as: mTab ↹/1-Tab ↹
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
Contributor
|
We have stalebot problems! |
spag Co-authored-by: Alasdair Smith <[email protected]>
Contributor
|
@40thieves Seems like it's working exactly as intended to me 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm test now runs all tests. Running only the mandatory tests is described in the README.
Suggestion for when we have auto running of tests on commit would be to add an npm script that is run with
npm run post-commitor something like that (that would only run the mandatory tests and not the extra?)View rendered README.md