Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

NW-5 Manchester- KHADAR M DAGAL - JavaScript-Core-1-Coursework-Week1#382

Open
khmdagal wants to merge 20 commits intoCodeYourFuture:masterfrom
khmdagal:master
Open

NW-5 Manchester- KHADAR M DAGAL - JavaScript-Core-1-Coursework-Week1#382
khmdagal wants to merge 20 commits intoCodeYourFuture:masterfrom
khmdagal:master

Conversation

@khmdagal
Copy link
Copy Markdown

@khmdagal khmdagal commented Aug 24, 2022

Copy link
Copy Markdown

@haroon-ali-dev haroon-ali-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

Comment thread mandatory/1-syntax-errors.js
Comment thread mandatory/3-function-output.js
Copy link
Copy Markdown

@jo-joanna jo-joanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! keep going!

Comment thread exercises/E-strings-concatenation/exercise.js
Comment thread exercises/G-numbers/exercise.js
Comment thread exercises/J-functions/exercise.js
Comment thread exercises/J-functions/exercise2.js
@Adibab
Copy link
Copy Markdown

Adibab commented Aug 28, 2022

Good work. Keep it up

Copy link
Copy Markdown

@Ara225 Ara225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I'm being nitpicky on purpose to just nudge you to perfection but it's really good overall!

Comment thread exercises/B-hello-world/exercise.js
@@ -1,3 +1,9 @@
// Start by creating a variable `message`

var name = "Adam";
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Var :(

@@ -1,2 +1,23 @@
var numberOfStudents = 15;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Var again


const double = Math.pow(findPowerOf, 2);

// result should 6, because it rounds to neares integer
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Comment thread exercises/K-functions-parameters/exercise.js
Comment thread extra/2-piping.js

function add() {

// adding two numbers
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing 👍

// There are syntax errors in this code - can you fix it to pass the tests?

function addNumbers(a b c) {
function addNumbers(a,b,c) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests passing on the mandatory stuff, good work

Math.random() = gives you random number between 0 to 1.

step 2
result of step one multiply by 10
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return word1.concat(word2);
/*
this is similar to word1 + word2;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

// Write the body of this function to concatenate three words together.
// Look at the test case below to understand what this function is expected to return.
return firstWord.concat(" ", secondWord, " ", thirdWord);
// return concatnatedTrimedwords.trim();
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out code

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants