Manchester NW5-Yousef Shaikhan-JavaScript-Week1#398
Manchester NW5-Yousef Shaikhan-JavaScript-Week1#398youweb3 wants to merge 2 commits intoCodeYourFuture:masterfrom
Conversation
| function getRandomNumber() { | ||
| return Math.random() * 10; | ||
| } | ||
| // this function means return a random number between 0(inclusive), and 10(exclusive) |
There was a problem hiding this comment.
Good job adding the comments
Comments should'nt be added at the bottom of your code. that is bad practise
| function combine2Words(word1, word2) { | ||
| return word1.concat(word2); | ||
| } | ||
| // the diffrent selection of the set of element taken one by one,or some join toghether |
|
|
||
| function calculateSalesTax() {} | ||
| function calculateSalesTax(price) { | ||
| return (price * 20) / 100; |
There was a problem hiding this comment.
This is nice.
First, you are not returning to the correct format with the £ symbol
|
Hi Yousef - thanks for submitting.
Now you need to format too. Did you look at toFixed in class? You can combine functions...
Also careful with concatenate. The test is asking for gaps between the strings Good effort but with test driven development keep working until the test passes. Steve |
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?