This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London Class 10 - Elena Barker - JS - Week 1#517
Open
ElenaBarker wants to merge 4 commits intoCodeYourFuture:masterfrom
Open
London Class 10 - Elena Barker - JS - Week 1#517ElenaBarker wants to merge 4 commits intoCodeYourFuture:masterfrom
ElenaBarker wants to merge 4 commits intoCodeYourFuture:masterfrom
Conversation
test passed
test passed
test passed
test passed
IrynaLypnyk
reviewed
Feb 21, 2023
| function addTaxAndFormatCurrency() {} | ||
| function addTaxAndFormatCurrency(taxPrice) { | ||
| let fullPrice = calculateSalesTax(taxPrice); | ||
| return "£" + fullPrice.toFixed(2) |
There was a problem hiding this comment.
It is also possible to use string interpolation here =)
return £{fullPrice.toFixed(2)``
IrynaLypnyk
reviewed
Feb 21, 2023
IrynaLypnyk
reviewed
Feb 21, 2023
| function concatenate(firstWord, secondWord, thirdWord) { | ||
| // Write the body of this function to concatenate three words together. | ||
| // Look at the test case below to understand what this function is expected to return. | ||
| return firstWord + " " + secondWord + " " + thirdWord |
There was a problem hiding this comment.
You could also make it with js concat method
return firstWord.concat(' ', secondWord, ' ', thirdWord);
Author
There was a problem hiding this comment.
Thank you very much for suggestion, will use it next time)
softacoder
reviewed
Feb 25, 2023
| function addNumbers(a b c) { | ||
| function addNumbers(a, b, c) { | ||
| return a + b + c; | ||
| } |
| function introduceMe(name, age) { | ||
| return `Hello, my name is ${name} and I am ${age} years old`; | ||
| } | ||
|
|
| total = a + b; | ||
|
|
||
| return "The total is total"; | ||
| return `The total is ${total}`; |
|
|
||
| function trimWord(word) { | ||
| return wordtrim(); | ||
| return word.trim(); |
|
|
||
| function getStringLength(word) { | ||
| return "word".length(); | ||
| return word.length; |
| a * b * c; | ||
| return; | ||
| return a * b * c; | ||
| ; |
There was a problem hiding this comment.
Consider: function multiply(a, b, c) {
const answer = a * b * c;
return answer;
}
| @@ -1,16 +1,15 @@ | |||
| // Add comments to explain what this function does. You're meant to use Google! | |||
| // The Math.round() method rounds a number to the nearest integer. This function also multiply youranswer by 10. | |||
| } | ||
|
|
||
| // Add comments to explain what this function does. You're meant to use Google! | ||
| // The concat() method returns the new string after merging the existing string with other strings without affecting the existing string. |
There was a problem hiding this comment.
Comment: I think your answer is much clearer than mine. Mine: I created a descriptive word to my function. The CONCAT function combines the text from multiple ranges and/or strings, but it doesn't provide delimiter or IgnoreEmpty arguments.
| function concatenate(firstWord, secondWord, thirdWord) { | ||
| // Write the body of this function to concatenate three words together. | ||
| // Look at the test case below to understand what this function is expected to return. | ||
| return firstWord + " " + secondWord + " " + thirdWord |
There was a problem hiding this comment.
Consider:
function concatenate(firstWord, secondWord, thirdWord) {
return firstWord.concat(" ", secondWord, " ", thirdWord);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard? I found a bit hard task 4 about taxes.
What do you still not understand?
Any other notes?