South Africa - Aitken Fortuin - JavaScript-Core-1-Coursework-Week1#53
South Africa - Aitken Fortuin - JavaScript-Core-1-Coursework-Week1#53SerialCarKey wants to merge 4 commits intoCodeYourFuture:masterfrom
Conversation
Completed first exercises
ShawenHarker
left a comment
There was a problem hiding this comment.
Hi Aitken,
Nice work man, really clean code, easy to read and understand what you are doing, but just a pro tip, when you abbreviate your names, can you make it a slight but more clear.
Keep up the good work man.
sinopungula
left a comment
There was a problem hiding this comment.
Just completed my review. Awesome, clean work. Great job!
| var numberOfMentors = 8; | ||
|
|
||
| let Total = numberOfMentors + numberOfStudents; | ||
| let TotalNOS = numberOfStudents / Total * 100; |
There was a problem hiding this comment.
Hey! Love the use of abbreviations, creative.
| total = a ++ b; | ||
|
|
||
| return "The total is total" | ||
| total = a + b; |
There was a problem hiding this comment.
Hi Aitken! This is David, your edu buddy, how are ya? While this code works, keep in mind that this is a global variable. Declaring a global variable like this inside a function is discouraged. You can read this https://stackoverflow.com/questions/10525582/why-are-global-variables-considered-bad-practice, or reach out to me if you have more questions.
|
|
||
| function calculateSalesTax() {} | ||
| function calculateSalesTax(sales) { | ||
| return sales + (20 / 100) * sales; |
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
Completed first exercises
Your Details
Homework Details