London 10-Anu Thapaliya-js2-week1#249
London 10-Anu Thapaliya-js2-week1#249anuthapaliy wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
| @@ -22,4 +22,38 @@ | |||
| You should write and log at least 5 recipes | |||
| */ | |||
|
|
|||
There was a problem hiding this comment.
The recipe objects look good 👍
But take another look at the instructions on lines 13-20. It looks each recipe should be output in this way:
Mole
Serves: 2
Ingredients:
cinnamon
cumin
cocoa
|
|
||
| function createLookup(countryCurrencyCodes) { | ||
| // write code here | ||
| } |
|
|
||
| function createShoppingList(recipe) { | ||
| // write code here | ||
| } |
There was a problem hiding this comment.
This looks good to me 👍
As an extra challenge, can you re-write this using the filter array method?
| for (let ingredient of recipe.ingredients) | ||
| { | ||
|
|
||
| if (pantry.fridgeContents.includes(ingredient)=== false |
There was a problem hiding this comment.
When you see something like this: pantry.fridgeContents.includes(ingredient) === false - you can re-write it like this: !pantry.fridgeContents.includes(ingredient). Can you think of why that works?
|
|
||
| let cashRegister = { | ||
| // write code here | ||
| } |
| /* | ||
| Write a test that checks a score of 55 is grade D | ||
| */ | ||
|
|
There was a problem hiding this comment.
The tests above look good.
But below - it looks like you are missing toEqual?
| } | ||
| */ | ||
|
|
||
| /* |
There was a problem hiding this comment.
These are great, well done!
Good test names as well 😄
|
Nice work on this coursework @anuthapaliy! |
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?