This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London - Class10 | Akram Izedi | JS-Core-2|Week1#255
Open
AkramIzedi wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
London - Class10 | Akram Izedi | JS-Core-2|Week1#255AkramIzedi wants to merge 1 commit intoCodeYourFuture:mainfrom
AkramIzedi wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
mira-shukla
reviewed
May 12, 2023
| servings : 2 , | ||
| ingredients :['cinnamon' , 'cumin' , 'cocoa' ] | ||
| }; | ||
|
|
There was a problem hiding this comment.
do you use a linting service to make the formatting easier in vscode? https://eslint.org/
mira-shukla
reviewed
May 12, 2023
| name : recipe.name, | ||
| items : shoppingList, | ||
| } | ||
|
|
mira-shukla
reviewed
May 12, 2023
| let countryCurrency = countryCurrencyCode[1]; | ||
| currencyCodeLook[countryCode]=countryCurrency; | ||
| }; | ||
| return currencyCodeLook; |
There was a problem hiding this comment.
Instead of using for loops you could also use this https://www.w3schools.com/jsref/jsref_foreach.asp
mira-shukla
reviewed
May 12, 2023
mira-shukla
left a comment
There was a problem hiding this comment.
Really good work just some small improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?