This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Some minor review comments#52
Merged
40thieves merged 3 commits intoCodeYourFuture:add-more-exerisesfrom Mar 13, 2021
Merged
Conversation
Contributor
|
Thanks @illicitonion, those changes look good. I'm afraid my latest commit has caused some conflicts though. Would you mind fixing those up and I'll merge this. |
The comments and prompts all use lower-case, and I feel like there's enough for the trainees to be thinking about without having to think about case-normalisation...
When I didn't guard setting `this.currentRoom` in `move`, the error message told me to make sure my `start` method was correct. While "Sometimes the error message is misleading" is a good thing for our trainees to learn, I'm not sure this is the place, as there's already a lot of new things to grasp in this exercise.
Member
Author
|
Rebased! Thanks! |
Contributor
|
Merging, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a go at doing the exercise, and these stumbling blocks felt worth overcoming (see each individual commit, which has an explanation in the message).
This PR is targeting @40thieves' branch, so will add to their pull request if merged.