This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Fix incorrect room objects in choose-your-own-adventure exercise #78
Merged
ChrisOwen101 merged 2 commits intomainfrom Mar 26, 2021
Merged
Fix incorrect room objects in choose-your-own-adventure exercise #78ChrisOwen101 merged 2 commits intomainfrom
ChrisOwen101 merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the choose-your-own-adventure exercise so that the direction properties in room objects are all functions, instead of null or functions. This caused trainees to add additional type checking in their solutions.
I also added some additional error checking to the skeleton code, as one of the trainee's solutions was on the right lines, but slightly off.
This was brought up in feedback from London Class 7 trainees in this Slack thread
@illicitonion
@ChrisOwen101