This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Jestify 4-waterbottle and 11-choose-your-own-adventure#90
Merged
gregdyke merged 2 commits intoCodeYourFuture:mainfrom Jul 24, 2021
Merged
Jestify 4-waterbottle and 11-choose-your-own-adventure#90gregdyke merged 2 commits intoCodeYourFuture:mainfrom
gregdyke merged 2 commits intoCodeYourFuture:mainfrom
Conversation
water bottle - replact chain of calls of the api with individual tests - reorganise tests so that pour/drink/isEmpty/isFull can be implemented independently (and cause some tests to turn green) choose your own adventure - two run modes: npm test for jest, node for CLI game See equivalent PR/discussion in solutions repo https://github.com/CodeYourFuture/JavaScript-Core-2-Coursework-Week1-Solution/pull/7
illicitonion
approved these changes
Jul 1, 2021
| south or west. | ||
|
|
||
| To start the game, run this file with Node as usual. To stop the game, press | ||
| To start the game, run this file with Node: |
Member
There was a problem hiding this comment.
Suggested change
| To start the game, run this file with Node: | |
| To start the game, run this file with Node. Depending on your current directory, run one of: |
| expect(bottle.isEmpty()).toEqual(true); | ||
| }); | ||
|
|
||
| test("Given an empty bottle, when pour is called, then the volume does decrease", () => { |
Member
There was a problem hiding this comment.
As with the other PR - this test description/body are mismatched :)
40thieves
approved these changes
Jul 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
water bottle
choose your own adventure
See equivalent PR/discussion in solutions repo https://github.com/CodeYourFuture/JavaScript-Core-2-Coursework-Week1-Solution/pull/7