This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Conversation
Switch and to or, fixing bug where starting the game with no room would not trigger the check.
Contributor
Author
|
I'll work up a solution PR too. Now done: https://github.com/CodeYourFuture/JavaScript-Core-2-Coursework-Week1-Solution/pull/8 |
illicitonion
approved these changes
Jul 25, 2021
Contributor
Author
|
Pushed a change to match discussion in https://github.com/CodeYourFuture/JavaScript-Core-2-Coursework-Week1-Solution/pull/8 @illicitonion not sure if you want to re-review? I'll give it a day before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switch and to or, fixing bug where starting the game with no room would not trigger the check. Fixes CodeYourFuture/JavaScript-Core-2-Coursework-Week1#92.
Who Needs to Know?
@mrmikeshields-cyf
@illicitonion