This repository was archived by the owner on Jan 3, 2023. It is now read-only.
West Midlands Class 3 - Tom Rafferty - JavaScript Core 2 - Week 3#107
Open
TomRafferty wants to merge 9 commits intoCodeYourFuture:mainfrom
Open
West Midlands Class 3 - Tom Rafferty - JavaScript Core 2 - Week 3#107TomRafferty wants to merge 9 commits intoCodeYourFuture:mainfrom
TomRafferty wants to merge 9 commits intoCodeYourFuture:mainfrom
Conversation
missing extra task - I may come back and finish it, if I get all of my work in on time.
the alarm works as intended - just doesn't format the seconds into minutes/hours of which I have no idea how to implement effectively.
doesn't have nice css on auto button yet
added proper time and also css to button
both extras have been completed but I'm unclear on how well they work
tenzyns
reviewed
Oct 22, 2021
| let count = 0; | ||
| //clear movies from DOM | ||
| for(let i = 0; i < allMoviesDiv.childNodes.length - 1; i++){ | ||
| //start at the end |
There was a problem hiding this comment.
what does this loop do? the variable i is not used within the { }.
tenzyns
reviewed
Oct 22, 2021
| allMoviesDiv.lastChild.remove() | ||
| } | ||
| function writeMoviePerSecond(){ | ||
| if(count < movieArray.length){ |
There was a problem hiding this comment.
where is the movieArray defined or did you mean to type movies.length?
|
I have completed the review. Well done Tom. you have written them very well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your Details
Homework Details