Skip to content
This repository was archived by the owner on Jan 3, 2023. It is now read-only.

WM3 - Peter Ahern - JS2 - Week 3#110

Open
PeterAhern wants to merge 4 commits intoCodeYourFuture:mainfrom
PeterAhern:main
Open

WM3 - Peter Ahern - JS2 - Week 3#110
PeterAhern wants to merge 4 commits intoCodeYourFuture:mainfrom
PeterAhern:main

Conversation

@PeterAhern
Copy link
Copy Markdown

Your Details

  • Your Name: Peter Ahern
  • Your City: Birmingham
  • Your Slack Name: PeterAhern

Homework Details

  • Module: JS2
  • Week:3

Alarm Clock exercise complete, but with some functionality issues.
Stop button not functioning currently. Need to fix.
Stop button fixed, working correctly.
@TomRafferty
Copy link
Copy Markdown

TomRafferty commented Oct 21, 2021

Peer Review Assignment
Hi Pete!
Your code all looks very well structured and written.
If I was to be really nit picky I’d say for (I believe line 19 on alarm clock) I’d have gone for if the time left is <= 0 as opposed to time left === 0. Again this is very nit picky but it should ensure that if the timer ends up goin down to -0.01 or something the code would still work.
All the best and keep up the great work!
EDIT: typo

Copy link
Copy Markdown

@Halla-S Halla-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Peter , I like your way of using a boolean in your setAlarm function.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants