This repository was archived by the owner on Jan 3, 2023. It is now read-only.
South-Africa - Erick Mulindi - JS_Core_2_3 - Week 11#51
Open
mulindierick wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
South-Africa - Erick Mulindi - JS_Core_2_3 - Week 11#51mulindierick wants to merge 2 commits intoCodeYourFuture:mainfrom
mulindierick wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
Finished all mandatory exercises
|
Hi Erick you did some great work there my friend, keep it up |
ezekiel444
reviewed
Apr 3, 2021
ezekiel444
left a comment
There was a problem hiding this comment.
Awesome Erick. But:
-
DOM practice is ignore
-
ALARM stop function is not working and when a negative value is entered it defiles the purpose of the code and start incrementing in negative number
-
quotes line 500 bad name of your element id 'button'
-
bad practice invoking your click button function inside your html also the function is throwing an error when fired.
-
slide show press all the button from first to last and your will get an error in the console because your are not clearing properly the settimeoutinterval
Did all extra challenges
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished all mandatory exercises
Your Details
Homework Details