This repository was archived by the owner on Mar 12, 2025. It is now read-only.
Fix mb_stripos offset parameter for php 8.1#98
Merged
Naktibalda merged 2 commits intoCodeception:9.0from Jan 26, 2022
Merged
Conversation
Member
|
Thanks, could you make another pull request and update https://github.com/Codeception/Codeception/blob/5.0/src/PHPUnit/Constraint/Page.php too ? |
Member
|
I fixed CI in 9.0 branch, please update your branch. |
Contributor
Author
|
Hello I checked https://github.com/Codeception/Codeception/blob/5.0/src/PHPUnit/Constraint/Page.php and mb_stripos seems to already have correct parameter (0 instead of null) |
Contributor
Author
|
Branch updated, I hope |
Contributor
Author
|
Any idea as to when this could be tagged? :) |
Member
|
Released as 9.0.7 |
Contributor
Author
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without this the method throws deprecation warning
mb_stripos(): Passing null to parameter #3 ($offset) of type int is deprecated