Skip to content

refactor!: use FutureOr to allow synchronous interceptors#144

Merged
CodingAleCR merged 1 commit intoCodingAleCR:mainfrom
Leptopoda:refactor/use_futureOr_in_interfaces
Jul 7, 2024
Merged

refactor!: use FutureOr to allow synchronous interceptors#144
CodingAleCR merged 1 commit intoCodingAleCR:mainfrom
Leptopoda:refactor/use_futureOr_in_interfaces

Conversation

@Leptopoda
Copy link
Copy Markdown
Contributor

@Leptopoda Leptopoda commented Jun 12, 2024

This allows synchronous implementations for interceptors.

@CodingAleCR
Copy link
Copy Markdown
Owner

Interesting, what is your use case?

Also, it would be great if you update the examples and the docs along with the library's code.

Thank you!

@Leptopoda
Copy link
Copy Markdown
Contributor Author

Sorry for my delay.
The idea is that we mostly use synchronous interceptors so one can add a separate subclass that only allows synchronous methods.
If used in a custom http client one would not get the async suspension.

@CodingAleCR CodingAleCR merged commit f54a401 into CodingAleCR:main Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants