Update references, docs, and check-issue skill#188
Merged
Conversation
The collaboration workflow draft has been reviewed and filed as GitHub issue #187 for further refinement and discussion. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 96.88% 96.88%
=======================================
Files 200 200
Lines 27537 27537
=======================================
Hits 26680 26680
Misses 857 857 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GiggleLiu
commented
Mar 6, 2026
There was a problem hiding this comment.
Pull request overview
This PR expands contributor tooling and documentation, adds a new “check-issue” skill reference set, and enhances the CLI’s path output to include composed “overall overhead” for multi-step reduction paths (with accompanying integration tests). It also introduces an interactive module-architecture visualization in the mdBook docs and adds a complexity/overhead review page.
Changes:
- Add interactive module architecture graph generation + rendering for mdBook docs.
- Add composed
overall_overheadto CLI path JSON/text output + new CLI integration tests. - Add new documentation/reference materials (complexity review page, Karp rules reference, check-issue skill design + reference whitelist).
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/gen_module_graph.py | New generator that converts rustdoc JSON into a Cytoscape-ready module graph JSON. |
| docs/src/static/module-graph.js | New client-side Cytoscape rendering, interaction, and tooltip behavior for the module graph. |
| docs/src/static/module-graph.css | Styling for the module graph container, legend, and tooltip. |
| docs/src/design.md | Replaces static SVG module overview with interactive module graph embed. |
| book.toml | Registers the new module-graph JS/CSS as mdBook assets. |
| Makefile | Updates mdbook target output formatting (but introduces piping concerns). |
| problemreductions-cli/src/commands/graph.rs | Adds composed “Overall” overhead section (text) and overall_overhead field (JSON). |
| problemreductions-cli/src/mcp/tools.rs | Adds overall_overhead to MCP tool JSON output for path. |
| problemreductions-cli/tests/cli_tests.rs | Adds integration tests validating “Overall” overhead presence + JSON shape + composition behavior. |
| docs/src/complexity-review.md | New documentation page tracking complexity/overhead correctness reviews. |
| docs/src/SUMMARY.md | Adds the new complexity review page to the mdBook TOC. |
| references/rules-karp.md | Adds a Karp (PLDI 2022) reduction rules reference page. |
| docs/plans/2026-03-05-check-issue-skill-design.md | Design plan for the new /check-issue workflow and checks. |
| .claude/skills/check-issue/SKILL.md | Adds the “check-issue” skill implementation guide. |
| .claude/skills/check-issue/references.md | Adds the curated reference/whitelist knowledge base for issue fact-checking. |
| .claude/skills/review-implementation/SKILL.md | Extends implementation review skill to include updating the complexity review table. |
| .claude/CLAUDE.md | Registers the new “check-issue” skill in the skills list. |
| Cargo.toml | Tweaks release profile (codegen-units=1, strip=true). |
| .gitignore | Adds docs/test-reports/ to ignored outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Step 1a now prints counts for each source and labels them clearly - Triage table separates user comments (priority 2) from Copilot (priority 3) - Added "User comments always take priority" instruction - Deleted stale plan file per reviewer request Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check-issueskill with reference whitelist for validating [Rule] and [Model] issuestest-featureskill for user-perspective feature testingreferences/rules-karp.md)collaborate.md— content moved to Formalize collaboration workflow for human contributors #187 for discussionTest plan
make checkpassesmake docbuilds with new module graph page🤖 Generated with Claude Code