Fix paper citations from issue #126 and #117 reviews#613
Merged
Conversation
PR #599 (KSat→SubsetSum): Fix imprecise Karp 1972 attribution — the direct 3-SAT→SubsetSum digit encoding follows Sipser (2012, Thm 7.56) and CLRS (2022, §34.5.5), not Karp's original reduction tree. Add bib entries for both textbooks. PR #570 (GraphPartitioning): Add proper @Citations for Garey, Johnson & Stockmeyer (1976) and Arora, Rao & Vazirani (2009) instead of plain-text references. Add bib entries for both papers. Regenerate problem_schemas.json and reduction_graph.json. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 210 210
Lines 28793 28793
=======================================
Hits 27796 27796
Misses 997 997 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Address review comment: explicitly state that brute-force O*(2^n) is the best known unconditional exact algorithm, and cite Cygan et al. (STOC 2014 / SICOMP 2019) for the FPT result parameterized by bisection width. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Add Step 1a between checkout and Copilot fixes to merge origin/main into the PR branch. Resolves simple conflicts automatically; aborts and reports for complex conflicts needing manual resolution. Co-Authored-By: Claude Opus 4.6 <[email protected]>
project-pipeline: Reorder Steps 0c/0d so eligibility check (source and target models exist) runs before scoring. Only eligible issues get scored. review-pipeline: Add Step 1a to merge origin/main into the PR branch before fixing Copilot comments, catching conflicts early. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sipser2012andcormen2022bib entries.@citationsyntax for Garey, Johnson & Stockmeyer (1976) and Arora, Rao & Vazirani (2009). Addgarey1976andarora2009bib entries.problem_schemas.jsonandreduction_graph.jsonTest plan
make paperbuilds clean🤖 Generated with Claude Code