Fix #255: Add SteinerTreeInGraphs model#623
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #623 +/- ##
========================================
Coverage 97.52% 97.52%
========================================
Files 367 369 +2
Lines 46439 46716 +277
========================================
+ Hits 45288 45560 +272
- Misses 1151 1156 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add the Steiner Tree in Graphs problem - a classical NP-complete network design problem about finding minimum-weight trees connecting terminal vertices in a graph. Changes: - New model: src/models/graph/steiner_tree_in_graphs.rs - Unit tests: 14 tests covering creation, evaluation, solver, serialization - CLI support: dispatch, alias, create command with --terminals flag - Paper documentation: problem-def with example figure and bibliography Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Collaborator
Author
Implementation SummaryChanges
Deviations from Plan
Open Questions
|
# Conflicts: # docs/paper/reductions.typ # docs/paper/references.bib # problemreductions-cli/src/cli.rs # problemreductions-cli/src/commands/create.rs # problemreductions-cli/src/dispatch.rs # problemreductions-cli/src/problem_name.rs # src/lib.rs # src/models/graph/mod.rs # src/models/mod.rs
Update declare_variants! to new syntax (default opt), add missing ProblemSchemaEntry fields (aliases, dimensions, display_name), remove duplicate parse_terminals function, and add missing import. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
…est, paper - Add canonical_model_example_specs() for example-db integration - Register in graph mod.rs example chain - Update complexity string from Dreyfus-Wagner to Bjorklund et al. (2^k * n^3) - Add brute-force verification to issue example test - Update paper to use load-model-example() instead of hand-written data Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
GiggleLiu
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the SteinerTreeInGraphs problem model — a classical NP-complete network design problem about finding minimum-weight trees connecting terminal vertices in a graph.
Fixes #255