Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
- Coverage 97.28% 97.28% -0.01%
==========================================
Files 320 322 +2
Lines 41399 41598 +199
==========================================
+ Hits 40277 40470 +193
- Misses 1122 1128 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Implementation SummaryChanges
Deviations from Plan
Open Questions
|
There was a problem hiding this comment.
Pull request overview
Adds the PrimeAttributeName satisfaction problem — a classical NP-complete problem from relational database theory (Garey & Johnson SR28). Given attributes, functional dependencies, and a query attribute, determines if the query belongs to any candidate key.
Changes:
- New model
PrimeAttributeNamewith closure computation, minimality checking, and full test suite - CLI integration with
--depsand--queryflags for creating instances - Documentation in the paper with a visual figure and mathematical description
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/models/set/prime_attribute_name.rs | Core model: struct, constructor with validation, closure computation, evaluate, schema registration |
| src/unit_tests/models/set/prime_attribute_name.rs | Comprehensive tests covering creation, evaluation, serialization, solver, and edge cases |
| src/models/set/mod.rs | Module registration and re-export |
| src/models/mod.rs | Public re-export |
| src/lib.rs | Prelude export |
| src/example_db/fixtures/examples.json | Canonical example fixture |
| problemreductions-cli/src/cli.rs | New --deps and --query CLI flags |
| problemreductions-cli/src/commands/create.rs | CLI create command handler with dependency parsing |
| docs/paper/reductions.typ | Paper documentation with figure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Review Pipeline Report
Remaining issues for final review
Notes
🤖 Generated by review-pipeline |
Resolve conflicts with PrecedenceConstrainedScheduling and other models added to main since branch diverged. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
zazabap
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add PrimeAttributeName satisfaction problem — a classical NP-complete problem from relational database theory (Garey & Johnson A4 SR28). Given attributes, functional dependencies, and a query attribute, determines if the query belongs to any candidate key.
Fixes #446