Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
==========================================
+ Coverage 97.32% 97.34% +0.02%
==========================================
Files 327 329 +2
Lines 42170 42297 +127
==========================================
+ Hits 41042 41175 +133
+ Misses 1128 1122 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Implement the reduction from MinimumMultiwayCut<SimpleGraph, i32> to QUBO<f64> using the one-hot vertex-terminal assignment encoding (Heidari, Dinneen & Delmas 2022). The QUBO Hamiltonian uses penalty terms for one-hot constraints and terminal pinning (H_A) plus cut cost encoding (H_B). Includes 4 unit tests covering closed-loop correctness, a small instance, size verification, and terminal pinning. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Add reduction rule from MinimumMultiwayCut to QUBO using the Heidari, Dinneen & Delmas (2022) penalty Hamiltonian formulation with kn binary variables encoding vertex-to-terminal assignments. - Reduction rule with one-hot + terminal pinning penalties (H_A) and cut-cost objective (H_B) - 4 unit tests including closed-loop verification - Canonical example in example_db - Paper entry with worked example in reductions.typ - Regenerated exports (reduction_graph.json, problem_schemas.json, fixtures) Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Implementation SummaryChanges
Deviations from Plan
Open Questions
|
Agentic Review ReportStructural Check
Result: 11/11 structural checks passed. Build: all tests pass, clippy clean. Semantic Review:
Issue Compliance (#186): 6/6 checks passed — source/target, algorithm, solution extraction, correctness, overhead, and example all match the linked issue. Quality CheckDesign Principles:
HCI: N/A (no CLI changes). Test Quality Issues:
Agentic Feature Tests
Cross-checks: All direct-solve vs solve-via-reduction results match across all tested instances (canonical 5-vertex, minimal 2-terminal, disconnected, K4). Issues found:
Both are caught by Generated by review-pipeline |
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
# Conflicts: # docs/paper/references.bib
The direct_best_example function was removed on main. Update to use the current rule_example_with_witness API with explicit solution pair. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Summary
Add reduction rule from MinimumMultiwayCut to QUBO using the Heidari, Dinneen & Delmas (2022) formulation with kn binary variables encoding vertex-to-terminal assignments via penalty Hamiltonian + cut-cost Hamiltonian.
Fixes #186