fix: resolve paper compilation errors and correct example narrative#699
Merged
fix: resolve paper compilation errors and correct example narrative#699
Conversation
- PrimeAttributeName: replace nonexistent `x.samples` / `x.optimal` with `x.optimal_config` and a computed satisfying-count - ConsecutiveOnesSubmatrix: same `x.samples` fix - Add missing `booth1976` bibliography entry (Booth & Lueker, JCSS 1976) - StrongConnectivityAugmentation: fix incorrect claim that all candidate arcs are within budget — the direct arc (v4,v0) has weight 10 > B=8, so the narrative now explains the two-hop return path Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
=======================================
Coverage 97.31% 97.31%
=======================================
Files 324 324
Lines 41853 41853
=======================================
Hits 40731 40731
Misses 1122 1122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zazabap
approved these changes
Mar 19, 2026
Collaborator
zazabap
left a comment
There was a problem hiding this comment.
All CI checks pass. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x.samples/x.optimalkeys withx.optimal_config, fixingtypst compileerrorsbooth1976bibliography entry (Booth & Lueker, JCSS 1976) referenced by the ConsecutiveOnesSubmatrix sectionTest plan
typst compile --root . docs/paper/reductions.typsucceeds with no errors🤖 Generated with Claude Code