Conversation
…amples - Add find_all_satisfying + empty tests for 5 satisfaction models: SequencingWithinIntervals (41 solutions), ShortestCommonSupersequence (42), MultiprocessorScheduling (2), FlowShopScheduling (99), RuralPostman (1) - Update canonical examples for SequencingWithinIntervals and ShortestCommonSupersequence to use natural instances matching their issues - Register canonical_model_example_specs for 7 missing models: BinPacking, GraphPartitioning, Knapsack, MinimumFeedbackArcSet, OptimalLinearArrangement, SubgraphIsomorphism, SubsetSum (70/70 now) - Convert all 7 paper entries from hardcoded to data-driven load-model-example Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
…eduling.rs Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
…sfying-and-canonical-examples # Conflicts: # src/models/mod.rs
GraphPartitioning/SimpleGraph now has a canonical example, so switch the test to MaximumIndependentSet/KingsSubgraph/One which does not. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
==========================================
+ Coverage 97.38% 97.40% +0.01%
==========================================
Files 341 341
Lines 43659 43884 +225
==========================================
+ Hits 42519 42744 +225
Misses 1140 1140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_all_satisfying+ empty tests for 5 satisfaction models that were missing them: SequencingWithinIntervals, ShortestCommonSupersequence, MultiprocessorScheduling, FlowShopScheduling, RuralPostmancanonical_model_example_specsfor 7 models that were missing them: BinPacking, GraphPartitioning, Knapsack, MinimumFeedbackArcSet, OptimalLinearArrangement, SubgraphIsomorphism, SubsetSum (all 70 problem types now registered)load-model-exampleTest plan
make checkpasses (fmt + clippy + all tests)make papercompiles successfullymodel_specs_are_self_consistentvalidates all configsmodel_specs_are_optimalconfirms optimality via solverfind_all_satisfyingtests verify exact solution counts withsolutions.contains(canonical_config)Closes #701
🤖 Generated with Claude Code