Ccf 11021 validate configure by jgielstra-cs · Pull Request #189 · CognitiveScale/cortex-cli

jgielstra-cs · 2019-05-13T20:09:10Z

Checklist:

Please check you fulfill ALL of the relevant checkboxes

Notified docs of any potential USER-facing changes
Added short description of the change - with relevant motivation and context.
Branch has the ticket number in its name (along with a ticket summary)
Commented the code, particularly in hard-to-understand areas
Added tests that prove my fix is effective or that my feature works
Ran npm test and it passes
Changes generate no new warnings

src/commands/configure.js

* Add validations for url, accounts, user, password * Fix messages * Add support for CORTEX_URI * Fixed per review comments, support - in URL, remove dead redundant code

* CCF-9286: return instanceId in the message when promoting a snapshot … (#162) * CCF-9286: return instanceId in the message when promoting a snapshot to an environment that was being returned by the api response but not getting included in the cli response * updated message with review comments * fixing undefined error when promoting a snapshot to an environment, instanceId is under `response.message.instanceId` (#164) * Add agents list-snapshot-instances (#168) * Fix invalid query param on list snap instances (#170) * Update minor-compatible dependencies * Tweaks to error handling (#183) * Added npm publish to build.sh. (#190) * Ccf 11021 validate configure (#189) * Add validations for url, accounts, user, password * Fix messages * Add support for CORTEX_URI * Fixed per review comments, support - in URL, remove dead redundant code * Adds support for Graph, Profiles, and Experiments APIs (#180) * Revved generator version and cli version. * Ccf 9171 memory vcpu mismatch (#155) * don't use default command line params for memory and vcpus * 0.12.9 * Bump lodash for vunerabilities CCF-9252 update generator for linux * CCF-9376 update generator version to 0.3.18 (#163) * CCF-9286: return instanceId in the message when promoting a snapshot … (#162) * CCF-9286: return instanceId in the message when promoting a snapshot to an environment that was being returned by the api response but not getting included in the cli response * updated message with review comments * fixing undefined error when promoting a snapshot to an environment, instanceId is under `response.message.instanceId` (#164) * working recursive upload of directory (#165) * working recursive upload of directory * 0.12.12 * Remove cortex-processors commands (#166) * Add agents list-snapshot-instances (#168) * Chunk directory upload (#169) * use sequential chunks of files to upload * 0.12.13 * Fix invalid query param on list snap instances (#170) * Updated list-services command to display the parameter names/types as well (#171) * CCF-9783 reverting changes to agent and catalog (#173) * Remove --timeout option from actions deploy (#175) * Ccf 9955 configure url (#176) * add protocol prefix if one is missing * 0.12.14 * Adds support for graph and profile APIs * Return error message from content upload properly * Bump generator-cortex to pick up with_type change * Support graph query in CLI * created template checklist as POC * updated pull_request_template * Update pull_request_template.md * Adds CLI support for Cortex Experiments * Adds progress bar to graph event publish for files * Bug fixes when attempting to craft manual test cases for the cli. * Reved package-log * Bumped version of cli and add proxying support * 0.12.17

jgielstra-cs added 3 commits May 13, 2019 15:05

Add validations for url, accounts, user, password

6814653

Fix messages

f8ed88f

tweak to error message

26e3647

jgielstra-cs requested review from clee-cs, dwisecup-cs, mreyna-cs and vadan-cs May 20, 2019 14:25

clee-cs reviewed May 20, 2019

View reviewed changes