This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Merged
Conversation
* Rebased marketplace commands and bump to v0.3.23 * Fix package-lock.json to have new generator version * removed unused imports * removed unused imports
* CCF-11947 parse vcpus as a float * CCF-11947 parse vcpus as a float
* CCF-11830 handle zeros in mem and vcpus * CCF-11830 handle zeros in ttl
bumped generator version to `0.3.24`
* CCF-12167 Change compatibility errors to warnings * Change console.print -> printWarning * tweaks per pr comments * Fix per review comments, updated test case to match new warning only behavior when unable to contact npm central
* Revved generator version and cli version. * Ccf 9171 memory vcpu mismatch (#155) * don't use default command line params for memory and vcpus * 0.12.9 * Bump lodash for vunerabilities CCF-9252 update generator for linux * CCF-9376 update generator version to 0.3.18 (#163) * CCF-9286: return instanceId in the message when promoting a snapshot … (#162) * CCF-9286: return instanceId in the message when promoting a snapshot to an environment that was being returned by the api response but not getting included in the cli response * updated message with review comments * fixing undefined error when promoting a snapshot to an environment, instanceId is under `response.message.instanceId` (#164) * working recursive upload of directory (#165) * working recursive upload of directory * 0.12.12 * Remove cortex-processors commands (#166) * Add agents list-snapshot-instances (#168) * Chunk directory upload (#169) * use sequential chunks of files to upload * 0.12.13 * Fix invalid query param on list snap instances (#170) * Updated list-services command to display the parameter names/types as well (#171) * CCF-9783 reverting changes to agent and catalog (#173) * Remove --timeout option from actions deploy (#175) * Ccf 9955 configure url (#176) * add protocol prefix if one is missing * 0.12.14 * Adds support for graph and profile APIs * Return error message from content upload properly * Bump generator-cortex to pick up with_type change * Support graph query in CLI * created template checklist as POC * updated pull_request_template * Update pull_request_template.md * Adds CLI support for Cortex Experiments * Adds progress bar to graph event publish for files * Bump lodash for vunerabilities CCF-9252 update generator for linux * CCF-9376 update generator version to 0.3.18 (#163) * CCF-9286: return instanceId in the message when promoting a snapshot … (#162) * CCF-9286: return instanceId in the message when promoting a snapshot to an environment that was being returned by the api response but not getting included in the cli response * updated message with review comments * fixing undefined error when promoting a snapshot to an environment, instanceId is under `response.message.instanceId` (#164) * working recursive upload of directory (#165) * working recursive upload of directory * 0.12.12 * Add agents list-snapshot-instances (#168) * Chunk directory upload (#169) * use sequential chunks of files to upload * 0.12.13 * Fix invalid query param on list snap instances (#170) * Updated list-services command to display the parameter names/types as well (#171) * CCF-9783 reverting changes to agent and catalog (#173) * Remove --timeout option from actions deploy (#175) * Ccf 9955 configure url (#176) * add protocol prefix if one is missing * 0.12.14 * Bump generator-cortex to pick up with_type change * Return error message from content upload properly * created template checklist as POC * updated pull_request_template * Update pull_request_template.md * Fixed bugs in list-services update (#174) * Revved generator version and cli version. * Ccf 9171 memory vcpu mismatch (#155) * don't use default command line params for memory and vcpus * 0.12.9 * Bump lodash for vunerabilities CCF-9252 update generator for linux * CCF-9376 update generator version to 0.3.18 (#163) * CCF-9286: return instanceId in the message when promoting a snapshot … (#162) * CCF-9286: return instanceId in the message when promoting a snapshot to an environment that was being returned by the api response but not getting included in the cli response * updated message with review comments * fixing undefined error when promoting a snapshot to an environment, instanceId is under `response.message.instanceId` (#164) * working recursive upload of directory (#165) * working recursive upload of directory * 0.12.12 * Remove cortex-processors commands (#166) * Add agents list-snapshot-instances (#168) * Chunk directory upload (#169) * use sequential chunks of files to upload * 0.12.13 * Fix invalid query param on list snap instances (#170) * Updated list-services command to display the parameter names/types as well (#171) * CCF-9783 reverting changes to agent and catalog (#173) * Fixed bugs in list-services update * Remove --timeout option from actions deploy (#175) * Ccf 9955 configure url (#176) * add protocol prefix if one is missing * 0.12.14 * Updated to handle parameters being null * Updated gitignore file to not include .DS_Store files * Return error message from content upload properly * Bump generator-cortex to pick up with_type change * Made code fixes per Davids suggestions * Update agents.js * Update catalog.js * Update .gitignore * Made changes from Davids review * Reverted gitignore * Update .gitignore * Update .gitignore * created template checklist as POC * updated pull_request_template * Update pull_request_template.md * Ccf 9171 memory vcpu mismatch (#155) * don't use default command line params for memory and vcpus * 0.12.9 * Bump lodash for vunerabilities CCF-9252 update generator for linux * CCF-9376 update generator version to 0.3.18 (#163) * CCF-9286: return instanceId in the message when promoting a snapshot … (#162) * CCF-9286: return instanceId in the message when promoting a snapshot to an environment that was being returned by the api response but not getting included in the cli response * updated message with review comments * Updated gitignore file to not include .DS_Store files * Made code fixes per Davids suggestions * Update .gitignore * Update .gitignore * Update .gitignore * first working pass, seems like all client methods are now proxied (#185) * first working pass, seems like all client methods are now proxied * added bypass proxy env variable * 0.12.15 * Adds support for publishing graph events from plain old JSON lines files * Update NPM deps post-merge with develop * Fixes event publish count in CLI progress bar. Adds graph publish retry support. * Ccf 9955 configure url (#176) * add protocol prefix if one is missing * 0.12.14 * CCF-9286: return instanceId in the message when promoting a snapshot … (#162) * CCF-9286: return instanceId in the message when promoting a snapshot to an environment that was being returned by the api response but not getting included in the cli response * updated message with review comments * fixing undefined error when promoting a snapshot to an environment, instanceId is under `response.message.instanceId` (#164) * working recursive upload of directory (#165) * working recursive upload of directory * 0.12.12 * Add agents list-snapshot-instances (#168) * Chunk directory upload (#169) * use sequential chunks of files to upload * 0.12.13 * Fix invalid query param on list snap instances (#170) * Update NPM deps post-merge with develop * Fixes event publish count in CLI progress bar. Adds graph publish retry support. * Added ability to batch entity events when publishing to the graph api based on REST request size limits. Also added cli command to list profile versions. * Added command to list profile versions. Also more limits when querying profiles. * Getting auto attributes to consider lists and dictionaries to dimensionals.
jgielstra-cs
approved these changes
Sep 20, 2019
Contributor
daldridge-cs
left a comment
There was a problem hiding this comment.
The marketplace and compatibility changes I reviewed before look to be there as expected. Omar's Profiles stuff looks decent (though my brain may explode trying to grok the chunked streaming stuff). Johan spotted the configuration validation checks wonkiness, which I've highlighted/commented in the PR. Tenantive rubber stamp 👍
…shing profile events. Also better errors for invalid events.
daldridge-cs
approved these changes
Oct 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Please check you fulfill ALL of the relevant checkboxes
npm testand it passes