This repository was archived by the owner on Apr 15, 2024. It is now read-only.
FAB-30 Added deploy snapshot command to export agent snapshot and generate manifest file#239
Conversation
… for CI deployment
… for CI deployment
jgielstra-cs
approved these changes
Oct 9, 2020
| .option('--no-compat', 'Ignore API compatibility checks') | ||
| .option('--color [on/off]', 'Turn on/off colors for JSON output.', 'on') | ||
| .option('--profile [profile]', 'The profile to use') | ||
| .option('-y, --yaml', 'Use YAML for snapshot export format') |
Contributor
There was a problem hiding this comment.
Does fabric accept both yaml or JSON ?
Just make yaml the default if that is what fabric accepts.
Collaborator
Author
There was a problem hiding this comment.
Yes, fabric accepts Agent Snapshot in both YAML and JSON (determines format based on file extension). Should I make YAML default and add -j/--json flag for JSON? -y is aligned with other commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Please check you fulfill ALL of the relevant checkboxes
npm testand it passes