Skip to content
This repository was archived by the owner on Apr 15, 2024. It is now read-only.

formatting changes for external-api skill type#273

Merged
ljha-CS merged 2 commits intodevelopfrom
FAB-230
Dec 5, 2020
Merged

formatting changes for external-api skill type#273
ljha-CS merged 2 commits intodevelopfrom
FAB-230

Conversation

@ljha-CS
Copy link
Copy Markdown
Collaborator

@ljha-CS ljha-CS commented Dec 5, 2020

Checklist:

Please check you fulfill ALL of the relevant checkboxes

  • Notified docs of any potential USER-facing changes
  • Added short description of the change - with relevant motivation and context.
  • Branch has the ticket number in its name (along with a ticket summary)
  • Commented the code, particularly in hard-to-understand areas
  • Added tests that prove my fix is effective or that my feature works
  • Ran npm test and it passes
  • Changes generate no new warnings

@ljha-CS ljha-CS requested a review from jgielstra-cs December 5, 2020 17:34
description: Response Content Type
defaultValue: 'application/json'
type: String
- name: headers.authorization
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljha-CS - @jgielstra-cs mentioned on the call today (I think before you joined) that while it's not required and his example didn't include it, it would be good to keep in the Authorization header block, so I think that can come back in

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mburpo-CS @jgielstra-cs Added Authorization header. Once review and merge.

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @ljha-CS.

@ljha-CS ljha-CS merged commit 8cfc4c1 into develop Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant