Skip to content
This repository was archived by the owner on Apr 15, 2024. It is now read-only.

FAB-673 Fix invoke skill JSON parse issue, fix skill save promise issue#274

Merged
jgielstra-cs merged 1 commit intodevelopfrom
FAB-673-invoke-err
Dec 5, 2020
Merged

FAB-673 Fix invoke skill JSON parse issue, fix skill save promise issue#274
jgielstra-cs merged 1 commit intodevelopfrom
FAB-673-invoke-err

Conversation

@jgielstra-cs
Copy link
Copy Markdown
Contributor

@jgielstra-cs jgielstra-cs commented Dec 5, 2020

Checklist:

Please check you fulfill ALL of the relevant checkboxes

  • Notified docs of any potential USER-facing changes
  • Added short description of the change - with relevant motivation and context.
  • Branch has the ticket number in its name (along with a ticket summary)
  • Commented the code, particularly in hard-to-understand areas
  • Added tests that prove my fix is effective or that my feature works
  • Ran npm test and it passes
  • Changes generate no new warnings

@jgielstra-cs jgielstra-cs merged commit f179670 into develop Dec 5, 2020
@jgielstra-cs jgielstra-cs deleted the FAB-673-invoke-err branch December 5, 2020 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vkarumuri-cs vkarumuri-cs Awaiting requested review from vkarumuri-cs

3 more reviewers

@clee-cs clee-cs clee-cs approved these changes

@jlara-cs jlara-cs jlara-cs approved these changes

@mcriscolo-cs mcriscolo-cs mcriscolo-cs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jgielstra-cs @clee-cs @jlara-cs @mcriscolo-cs