This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Conversation
ghost
reviewed
Dec 14, 2020
| description: Update default value to port on which app will be running | ||
| required: true | ||
| type: String | ||
| defaultValue: 5000 |
There was a problem hiding this comment.
@jgielstra-cs - is 5000 the right value to default here?
Collaborator
Author
There was a problem hiding this comment.
@mburpo-CS @jgielstra-cs In generated python code and Dockerfile, its port 5000, so need to use same in skill.yaml also. I believe we can use any port.
ghost
approved these changes
Dec 14, 2020
ghost
left a comment
There was a problem hiding this comment.
looks good to me; only question I had was on if 5000 is the right defaultValue too set the port to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Please check you fulfill ALL of the relevant checkboxes
npm testand it passes