Skip to content
This repository was archived by the owner on Apr 15, 2024. It is now read-only.

FAB-4784 delete types#587

Merged
yreddy-CS merged 4 commits intodevelopfrom
FAB-4784
Jun 21, 2022
Merged

FAB-4784 delete types#587
yreddy-CS merged 4 commits intodevelopfrom
FAB-4784

Conversation

@yreddy-CS
Copy link
Copy Markdown
Collaborator

@yreddy-CS yreddy-CS commented Jun 21, 2022

Checklist:

Please check you fulfill ALL of the relevant checkboxes

  • Notified docs of any potential USER-facing changes
  • Added short description of the change - with relevant motivation and context.
  • Branch has the ticket number in its name (along with a ticket summary)
  • Commented the code, particularly in hard-to-understand areas
  • Added tests that prove my fix is effective or that my feature works
  • Ran npm test and it passes
  • Changes generate no new warnings
  • Changes are backward compatible with older clusters

}
})
.catch((err) => {
printError(`Failed to describe type ${typeName}: ${err.status} ${err.message}`, options);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error messages both say "describe"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the error message

@yreddy-CS yreddy-CS merged commit d19de32 into develop Jun 21, 2022
@yreddy-CS yreddy-CS deleted the FAB-4784 branch June 21, 2022 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants