This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Merged
Conversation
…r date parsing.. - Modify task list to support tasks from mongo - Fix gh-got & got vuln Add --schduled to tasks list cli to show scheduled tasks Added command for schedule task, pause, resume Clean task list with scheduled tasks FAB-4477 sort options work for both other/new task apis
clee-cs
approved these changes
Jun 30, 2022
Contributor
clee-cs
left a comment
There was a problem hiding this comment.
LGTM, couple small comments for my own understanding.. trying to keep conversations out of slack DM's :)
| })); | ||
|
|
||
| // Pause a task | ||
| program |
Contributor
There was a problem hiding this comment.
pause and resume on scheduled tasks is basically undeploy and deploy?
Contributor
Author
There was a problem hiding this comment.
This is pause the schedule and resume schedule ... this needed some tweaks ...
|
|
||
| // Undeploy agent | ||
| program | ||
| .command('undeploy <agentNames...>') |
Contributor
There was a problem hiding this comment.
was kinda wondering if we should add a --all option for our undeploy commands to make it easier to cleanup all deployed resources for a project?..
Contributor
Author
There was a problem hiding this comment.
Put a ticket in ... all in project isn't a bad idea..
Contributor
There was a problem hiding this comment.
jgielstra-cs
added a commit
that referenced
this pull request
Jul 5, 2022
* - Use dayjs over momentjs, moment is in maintenance mode needed better date parsing.. - Modify task list to support tasks from mongo - Fix gh-got & got vuln Add --schduled to tasks list cli to show scheduled tasks Added command for schedule task, pause, resume Clean task list with scheduled tasks FAB-4477 sort options work for both other/new task apis * Tweak pause/resume cli option to make wording less confusing
yreddy-CS
added a commit
that referenced
this pull request
Jul 14, 2022
* Ensure LF's on Windows
* * Renamed generate command to workspace
* workspace command now creates skill templates fromn the cortex-code repository.
* Updated gitignore
* * Validate git token, and automatically run config if not configured.
* * Fixed up support for multiple config versions.
* Added new config version 4, which includes template repo config and IDE registry support.
* Properly handle default publish destination.
* Changed from workspace to workspaces
* * Moved workspace implementation into folder
* Removed old generate templates
* Build command works
* Started on publish command (incomplete)
* Minor code restructure
* Support removing encoding of repo url in skill.yaml
* Minor messaging changes
* More messaging fixes
* Fixed a problem with naming image
* Added registry management commands
* Indicate active registry in list
* Pass options to print routines to respect color option
* Changed subcommand to registry instead of registries
* Image name in skill needs to have the generated tag
* Fix to allow for templates in subfolders
* Minor cleanup and improved some messaging
* Fixes to tests so they work under Windows. All you Apple fanboys can suck it.
* Updated lockfile
* Minor fixes and improvements
* WIP
* Securely persist github token
* WIP
* Audit fixes
* Remove test command for now
* oops.
* Audit fix
* Removed allowList entry
* Updated lock file
* Fixed lint bug
* Fix vulns
* Fixed an incorrect import
* Moved typescript types for cortex into the CLI client.
* added prefix support for content
* Update cortex-skills.js
* Update tasks.js
* Use the slim python images as a default
* Update tasks.js
* Removed allowList entry
* Minor text formatting fix
* lint fix
* Added deprecation for generate command.
* lint fix
* Removed workspace test command. Will only support build and publish from now on.
* Added tests for generation
* show limit message
* lint fix
* Updated lockfile and fixed a small merge error
* Fixed lockfile with corrected npmrc file
* * Updated engines requirement to 16
* Disabled workspace tests in CI, due to keytar not having access to a keystore. Need to figure out a workaround.
* Use correct this context for test handler
* Add libsecret to CI image
* No sudo required
* And of course, we need to run update first.
* Add libsecret to CI container
* Does it need apt-utils?
* PUNT! Dont process docs for workspaces.
* removed unwanted options
* Removed some troubleshooting changes inavertently left in build.sh
* added default sort with {updatedAt: -1}
* fixes
* added code to catch error
* fix: upgrade minimatch from 3.0.4 to 3.1.2
Snyk has created this PR to upgrade minimatch from 3.0.4 to 3.1.2.
See this package in npm:
https://www.npmjs.com/package/minimatch
See this project in Snyk:
https://app.snyk.io/org/fabric-test-sast-and-sca/project/035a2f5b-5ee7-4ea1-90e2-f2a44f281ef8?utm_source=github&utm_medium=referral&page=upgrade-pr
* fixing params
* Added missing template vars: generatedFiles and template for CLI
* Add async await to top level script to see if this improves test behavior
* Minor version bumps for vulns
* switch offset back to skip for list-activations (#564)
* switch offset back to skip for list-activations
* Update agents.js
* merged with develop
* code refactor
* fixes
* FAB-1213 Options requiring a value should fail is value not provided, remove configure related stack traces
Tweak boolean options
Dedup header code and use defaultHeaders() function, fix placement of user-agent header
Fix --parmsFile => --paramsFile
make --color [boolean] still accepts on/off
* code refactor
* added unit tests to invalidate wrong updatedAt sort params
* removing filter option from connections list
* Use GET_DEFAULT_SORT_CLI_OPTION instead of hard-coded sort
* addressed feedback comments
* publish artifacts as part of the PR pipeline as well
* FAB-4534 fix duplicate alias for describing external roles
* mark actionDefinition as optional (#570)
* fix assessment create command, assessmentDefinition is optional
* merging with dev
* replace console.log with process.stderr
* added compatibility PR check
* Add TODO
* FAB-4479 add verbose flag to the cli output, include http request and response
* FAB-4479 verbose flag
* Glob starting with / generates bad paths ... /my/path/my/path/skill.yaml
* Enhance Skill/Agent save to make it variadic
* verbose and report options were not being passed correctly when getting an activation record
* expand debug output for getActivation
* removed extra param
* FAB-4579 renamed top level `verbose` option on cortex.js to `debug` as it was … (#575)
* renamed top level `verbose` option on cortex.js to `debug` as it was conflicting with the existing option available on the `cortex agents get-activation` command
* fixed debug option description
* Validate provided template name and show error when not found.
* Lint fix
* Lint fix
* Check that provided project name exists and error out if not.
* Remove registry option for generate
* Fixed registry deletion
* Force node version to 16.15.0 as 16.15.1 breaks the audit-ci tool, minor version bumps (#581)
* Added comment
* Fixed bug FAB-4650 (#583)
* Validate --skill parameter
* Makes --notree work just like --color
* Verify project in config file is valid.
* delete types
* fixed typos
* remove debug
* error if skill doesnt contain an action with applied podspec
* fixed typo
* Bump got from 11.8.3 to 11.8.5
Bumps [got](https://github.com/sindresorhus/got) from 11.8.3 to 11.8.5.
- [Release notes](https://github.com/sindresorhus/got/releases)
- [Commits](sindresorhus/got@v11.8.3...v11.8.5)
---
updated-dependencies:
- dependency-name: got
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <[email protected]>
* Update cortex-types.js (#590)
* FAB-4804 - Handle invalid skill name for publish, and improved status output. (#591)
Co-authored-by: dschueller-cs <[email protected]>
* FAB-4785 - Fix issue with content publishing (#592)
Co-authored-by: dschueller-cs <[email protected]>
* FAB-4817 - Fix error message to include max length, and remove suffix to fix issues with incorrect length checking. (#593)
Co-authored-by: dschueller-cs <[email protected]>
* FAB-4815 - Fixed problems with adding and removing registries (#594)
* FAB-4815 - Validate registry name on activation
* Fixed problems with adding and removing registries
Co-authored-by: dschueller-cs <[email protected]>
* FAB-4817 - Check for MIN name length (#596)
* Oops. Enforced the MAX length but not the MIN.
* Missing semicolon. Sigh.
* A more concise implementation, and fixed problems with repeated validation failures.
Co-authored-by: dschueller-cs <[email protected]>
* Fab 4030 (#597)
* initial commit
* consistent error message
* consistent list returns
* added test
* fixing integration tests
Co-authored-by: Akarsh <[email protected]>
* FAB-4838 - Show build status results correctly. (#599)
Co-authored-by: dschueller-cs <[email protected]>
* FAB-4626 - Dont allow skill generation over top of existing skill. (#598)
Co-authored-by: dschueller-cs <[email protected]>
* FAB-4815 - Dont allow "empty" registry name. (#600)
Co-authored-by: dschueller-cs <[email protected]>
* Taskv3 (#602)
* - Use dayjs over momentjs, moment is in maintenance mode needed better date parsing..
- Modify task list to support tasks from mongo
- Fix gh-got & got vuln
Add --schduled to tasks list cli to show scheduled tasks
Added command for schedule task, pause, resume
Clean task list with scheduled tasks
FAB-4477 sort options work for both other/new task apis
* Tweak pause/resume cli option to make wording less confusing
* Add duration plugin for dayjs to fix experiments list (#603)
* FAB-4838 - Fixed wrapping problem in CLI error output (#601)
Co-authored-by: dschueller-cs <[email protected]>
* Message when rows are limited
* Update tasks.js
Co-authored-by: Darren Schueller <[email protected]>
Co-authored-by: dschueller-cs <[email protected]>
Co-authored-by: Akarsh Prasad <[email protected]>
Co-authored-by: Johan Gielstra <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: Colton Lee <[email protected]>
Co-authored-by: Akarsh <[email protected]>
Co-authored-by: Akarsh P <[email protected]>
Co-authored-by: Supriya Singh <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Please check you fulfill ALL of the relevant checkboxes
npm testand it passes