Support custom chain ids#429
Merged
ManuelBilbao merged 4 commits intoCommit-Boost:mainfrom Mar 2, 2026
Merged
Conversation
bcc1b28 to
96d8640
Compare
jclapis
approved these changes
Mar 2, 2026
ManuelBilbao
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no way to specify a chain id for the
Customvariant of theChainenum. This will make it difficult to test Commit-Boost on a non-standard chain (i.e., a local Kurtosis instance) once functions likecompute_prop_commit_signing_root()are merged in.This PR adds a
chain_id: u64to theChain::Customenum variant. It also closes #419 and fixes broken PBS config tests from previous PRs.