Skip to content

[RFC] Add docs for the ThemeManager#123

Merged
batzen merged 12 commits intoControlzEx:developfrom
timunie:DocumentationThemeManager
Oct 3, 2020
Merged

[RFC] Add docs for the ThemeManager#123
batzen merged 12 commits intoControlzEx:developfrom
timunie:DocumentationThemeManager

Conversation

@timunie
Copy link
Copy Markdown
Contributor

@timunie timunie commented Jul 9, 2020

I am not sure if I wrote everything correctly.

  1. I don't understand what is going on in the detail, so I might have missed something
  2. I am not a native English speaker, so if someone is a native speaker feel free to report spelling errors.

@timunie timunie force-pushed the DocumentationThemeManager branch from 6cfa2ce to 4cdeaf1 Compare July 9, 2020 19:26
@timunie
Copy link
Copy Markdown
Contributor Author

timunie commented Jul 10, 2020

Tasks to do:

  • Add documentation to Theme Syncing
  • Add docs about detect the current Theme

- Detect Theme
- Sync with Windows
@batzen
Copy link
Copy Markdown
Member

batzen commented Jul 14, 2020

@timunie just ping me if you want me to have a look. Don't want to disturb you while you are still working on it.

@timunie
Copy link
Copy Markdown
Contributor Author

timunie commented Jul 14, 2020

Hi @batzen

Does it look so bad? This is all I know about ThemeManager. I already got people who understood it and were able to do the Theming.

If you can give me a feedback about what to add I would be happy to do so.

@batzen
Copy link
Copy Markdown
Member

batzen commented Jul 14, 2020

I didn't mean to say it's bad, sorry if it sounded like that. I just wanted to offer help but didn't want to interrupt your work with review comments. Will try to add some comments in the next few days. I wrote most of the code and even i discovered new usage scenarios while using it at work. 😂

@timunie
Copy link
Copy Markdown
Contributor Author

timunie commented Jul 14, 2020

I look forward to your comments or if you like it more direct changes.

Comment thread Wiki/ThemeManager.md Outdated
Comment thread Wiki/ThemeManager.md Outdated
Comment thread Wiki/ThemeManager.md Outdated
Copy link
Copy Markdown

@seba30 seba30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never done this before.

@batzen batzen merged commit 3a4ea65 into ControlzEx:develop Oct 3, 2020
@batzen
Copy link
Copy Markdown
Member

batzen commented Oct 3, 2020

@timunie Thanks for contributing this!!!

@timunie timunie deleted the DocumentationThemeManager branch October 4, 2020 08:58
@punker76 punker76 added this to the 4.4.0 milestone Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants