[RFC] Add docs for the ThemeManager#123
Merged
batzen merged 12 commits intoControlzEx:developfrom Oct 3, 2020
Merged
Conversation
6cfa2ce to
4cdeaf1
Compare
Contributor
Author
|
Tasks to do:
|
- Detect Theme - Sync with Windows
Member
|
@timunie just ping me if you want me to have a look. Don't want to disturb you while you are still working on it. |
Contributor
Author
|
Hi @batzen Does it look so bad? This is all I know about ThemeManager. I already got people who understood it and were able to do the Theming. If you can give me a feedback about what to add I would be happy to do so. |
Member
|
I didn't mean to say it's bad, sorry if it sounded like that. I just wanted to offer help but didn't want to interrupt your work with review comments. Will try to add some comments in the next few days. I wrote most of the code and even i discovered new usage scenarios while using it at work. 😂 |
Contributor
Author
|
I look forward to your comments or if you like it more direct changes. |
seba30
reviewed
Sep 15, 2020
seba30
reviewed
Sep 15, 2020
seba30
reviewed
Sep 15, 2020
Member
|
@timunie Thanks for contributing this!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure if I wrote everything correctly.