Fixed issue with maximizing window on secondary monitors#157
Merged
batzen merged 5 commits intoControlzEx:developfrom Jun 29, 2022
jizc:bugfix/fixed-maximize-on-left-monitor
Merged
Fixed issue with maximizing window on secondary monitors#157batzen merged 5 commits intoControlzEx:developfrom jizc:bugfix/fixed-maximize-on-left-monitor
batzen merged 5 commits intoControlzEx:developfrom
jizc:bugfix/fixed-maximize-on-left-monitor
Conversation
This fixes an issue with maximizing a window on a monitor to the left of the main monitor
punker76
approved these changes
Jun 28, 2022
Member
|
@jizc Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made to improve this project
This fixes an issue with maximizing a window on a monitor to the left of (or above) the main monitor. The root cause was the calculation of the
rightandbottomproperties in theToRECTmethod. This wrong calculation resulted inMonitorFromWindowPosOrWindowreturning the wrong monitor, which in turn made_HandleNCCALCSIZEnot work correctly.Unit test
Added test called
RectConvertedFromWindowPositionIsCorrectSize.Additional context
Before the fix
After the fix
