Skip to content

Fixing issues when taking screenshots#175

Merged
batzen merged 1 commit intodevelopfrom
issues/window_border_screenshot_2
Apr 11, 2023
Merged

Fixing issues when taking screenshots#175
batzen merged 1 commit intodevelopfrom
issues/window_border_screenshot_2

Conversation

@batzen
Copy link
Copy Markdown
Member

@batzen batzen commented Mar 31, 2023

Second try. ;-)

This requires every consumer to set a margin/padding on the content of the window when using any glow color.

This also fixes another issue i noticed while building this fix.
On Windows 11 when using the default window border the content misses one pixel on the top side.
That's best visible in the showcase applications window button where the top border is missing without using a margin/padding on the window content.

@batzen batzen requested a review from punker76 March 31, 2023 19:44
@batzen batzen added the Bug Fix label Mar 31, 2023
Copy link
Copy Markdown
Member

@punker76 punker76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batzen batzen merged commit c5033fb into develop Apr 11, 2023
@batzen batzen added this to the 6.0.0 milestone Apr 11, 2023
@batzen
Copy link
Copy Markdown
Member Author

batzen commented Apr 11, 2023

Will create a PR in MahApps.Metro to take the padding into account in the window style as soon as i find time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants