Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #154 +/- ##
===========================================
+ Coverage 76.74% 76.78% +0.04%
===========================================
Files 146 146
Lines 10890 10909 +19
===========================================
+ Hits 8357 8377 +20
+ Misses 1845 1843 -2
- Partials 688 689 +1 |
Codecov Report
@@ Coverage Diff @@
## develop #154 +/- ##
===========================================
+ Coverage 76.59% 76.77% +0.17%
===========================================
Files 146 146
Lines 10893 10903 +10
===========================================
+ Hits 8344 8371 +27
+ Misses 1858 1842 -16
+ Partials 691 690 -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tx flooding
The AddTx broadcasting needs a TTL control, or simply check local existence first.
DATARACE
Calling WaitGroup.Add in RPC handling goroutine main cause DATARACE: calls with a positive delta that occur when the counter is zero must happen before a Wait.
Use new WaitGroup instance while creating new sub-goroutines in a worker goroutine instead.
This also changes the broadcasting mode from nonblocking to blocking the worker goroutine -- but will be fine with the timeout context, if they work properly.
Nil field
Also check nil signee or signature in default verifier implementation.