Skip to content

Fix Makefile PHONY, add push_testnet#183

Merged
laodouya merged 3 commits intodevelopfrom
feature/fixMakefile
Jan 3, 2019
Merged

Fix Makefile PHONY, add push_testnet#183
laodouya merged 3 commits intodevelopfrom
feature/fixMakefile

Conversation

@auxten
Copy link
Contributor

@auxten auxten commented Jan 3, 2019

No description provided.

@auxten auxten requested review from laodouya and xq262144 January 3, 2019 04:01
Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approve.

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #183 into develop will increase coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #183      +/-   ##
===========================================
+ Coverage    76.95%   77.12%   +0.16%     
===========================================
  Files          135      135              
  Lines        10771    10771              
===========================================
+ Hits          8289     8307      +18     
+ Misses        1836     1820      -16     
+ Partials       646      644       -2

1 similar comment
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #183 into develop will increase coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #183      +/-   ##
===========================================
+ Coverage    76.95%   77.12%   +0.16%     
===========================================
  Files          135      135              
  Lines        10771    10771              
===========================================
+ Hits          8289     8307      +18     
+ Misses        1836     1820      -16     
+ Partials       646      644       -2

@laodouya laodouya merged commit cfaa1f4 into develop Jan 3, 2019
@laodouya laodouya deleted the feature/fixMakefile branch January 3, 2019 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants