Add metric web for cqld and cql-minerd#227
Merged
Conversation
added 9 commits
January 22, 2019 15:23
5bec8f5 to
7b8db5f
Compare
covenantdb
reviewed
Jan 22, 2019
covenantdb
reviewed
Jan 22, 2019
Codecov Report
@@ Coverage Diff @@
## develop #227 +/- ##
===========================================
+ Coverage 76.03% 76.08% +0.04%
===========================================
Files 136 139 +3
Lines 11281 11494 +213
===========================================
+ Hits 8578 8745 +167
- Misses 2046 2080 +34
- Partials 657 669 +12 |
Codecov Report
@@ Coverage Diff @@
## develop #227 +/- ##
===========================================
- Coverage 75.95% 75.91% -0.05%
===========================================
Files 136 139 +3
Lines 11287 11500 +213
===========================================
+ Hits 8573 8730 +157
- Misses 2053 2096 +43
- Partials 661 674 +13 |
leventeliu
reviewed
Jan 22, 2019
| EB int64 = TB * 1024 | ||
| // ZB is 1024 EB | ||
| ZB int64 = TB * 1024 | ||
| ) |
Contributor
There was a problem hiding this comment.
This can be refactored as:
// Defines byte units.
const (
_ = iota
KB int64 = 1 << (10 * iota)
MB
GB
TB
...
)
leventeliu
reviewed
Jan 22, 2019
| flag.Usage = func() { | ||
| fmt.Fprintf(os.Stderr, "\n%s\n\n", desc) | ||
| fmt.Fprintf(os.Stderr, "Usage: %s [arguments]\n", name) | ||
| _, _ = fmt.Fprintf(os.Stderr, "\n%s\n\n", desc) |
Contributor
Author
There was a problem hiding this comment.
Ignore return vars explicitly is recommend
added 2 commits
January 22, 2019 16:27
ggicci
approved these changes
Jan 22, 2019
added 2 commits
January 22, 2019 17:14
…QL into feature/httpMetric
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/debug/metricsfor chart and num/debug/varsfor json