Skip to content

Use ~/.cql/ directory as default config location.#233

Merged
xq262144 merged 28 commits intodevelopfrom
feature/dsn
Jan 28, 2019
Merged

Use ~/.cql/ directory as default config location.#233
xq262144 merged 28 commits intodevelopfrom
feature/dsn

Conversation

@laodouya
Copy link
Copy Markdown
Member

@laodouya laodouya commented Jan 24, 2019 •
edited
Loading

  1. Change all cmd config param to ~/.cql/config.yaml
  2. Config generate will default use ~/.cql/ as well.
  3. Driver can reduce client.Init func call if expected using ~/.cql/
  4. Update all unit test.
  5. Update all README.md
  6. Update client example.
  7. Compatible with elder usage.
  8. Skip compatibility test if branch name contains '/beta_'

laodouya added 24 commits January 23, 2019 22:09
@laodouya
Add osusergo build tag
7e8cde1
@laodouya
Add HomeDirExpand func in utils for home dir(~) expand
15ea0a0
@laodouya
Remove user params in HomeDirExpand func.
fe4c4e9
@laodouya
Remove unreachable code.
fd58b89
@laodouya
Change cql-utils use ~/.cql as config.yaml/private.key default location.
cd71df9
@laodouya
Update cql-utils docs. Disable keygen params
a948f24
@laodouya
Change cql to use ~/.cql as config.yaml default location.
7d6369d
@laodouya
Update testnet client test. Format cql-utils command help
0f1fdd8
@laodouya
Change cql-adapter to use ~/.cql as config.yaml default location.
3cdc4e9
@laodouya
Change cql-mysql-adapter to use ~/.cql as config.yaml default location.
e142bcc
@laodouya
Change cql-faucet to use ~/.cql as config.yaml default location.
a9cdb89
@laodouya
Change cql-explorer to use ~/.cql as config.yaml default location.
2e8a8f2
@laodouya
Change cql-fuse to use ~/.cql as config.yaml default location.
9f0b86d
@laodouya
Change cql-observer to use ~/.cql as config.yaml default location.
88fbd89
@laodouya
Set errexit pipefail for compatibility-testnet.
dd26565
@laodouya
Remove osusergo build tags. Add build tags for unittest.
1fd9871
@laodouya
Set -x for gitlabci process.
db97536
@laodouya
Fix go test unit test tags quote err.
682f729
@laodouya
Set -x for alltest.sh
48753cb
@laodouya
Move set -x location in alltest.sh
c5e317c
@laodouya
Change cql-minerd to use ~/.cql as config.yaml default location.
9d2c700
@laodouya
Change cqld to use ~/.cql as config.yaml default location.
54b5d50
@laodouya
Use default config file path(~/.cql/config.yaml) if driver not call I…
6be5079 
…nit.
@laodouya
Update client example
aea44af
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2019

Codecov Report

Merging #233 into develop will decrease coverage by 0.27%.
The diff coverage is 40%.

@@             Coverage Diff             @@
##           develop     #233      +/-   ##
===========================================
- Coverage    77.85%   77.57%   -0.28%     
===========================================
  Files          150      150              
  Lines        11914    11931      +17     
===========================================
- Hits          9276     9256      -20     
- Misses        1946     1977      +31     
- Partials       692      698       +6

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2019 •
edited
Loading

Codecov Report

Merging #233 into develop will decrease coverage by 0.25%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           develop    #233      +/-   ##
==========================================
- Coverage    77.85%   77.6%   -0.26%     
==========================================
  Files          150     150              
  Lines        11914   11931      +17     
==========================================
- Hits          9276    9259      -17     
- Misses        1946    1974      +28     
- Partials       692     698       +6

@laodouya laodouya requested review from ggicci and leventeliu January 24, 2019 06:44
ggicci
ggicci reviewed Jan 24, 2019
View reviewed changes
ggicci
ggicci reviewed Jan 24, 2019
View reviewed changes
auxten
auxten approved these changes Jan 28, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leventeliu
leventeliu approved these changes Jan 28, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xq262144 xq262144 merged commit c13a14c into develop Jan 28, 2019
@laodouya laodouya deleted the feature/dsn branch January 28, 2019 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggicci ggicci ggicci left review comments

@auxten auxten auxten approved these changes

@leventeliu leventeliu leventeliu approved these changes

@xq262144 xq262144 Awaiting requested review from xq262144

@zeqing-guo zeqing-guo Awaiting requested review from zeqing-guo

@foreseaz foreseaz Awaiting requested review from foreseaz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@laodouya @auxten @ggicci @leventeliu @xq262144