Skip to content

Unit all docker client config to same private.key#247

Merged
xq262144 merged 2 commits intodevelopfrom
feature/unit_client_config
Feb 2, 2019
Merged

Unit all docker client config to same private.key#247
xq262144 merged 2 commits intodevelopfrom
feature/unit_client_config

Conversation

@laodouya
Copy link
Copy Markdown
Member

@laodouya laodouya commented Feb 1, 2019

For docker-compose env:

  1. Delete unnecessary client config.
  2. Use same private key for all client role.
  3. Generate their own NodeID for each client role by same key.

@laodouya laodouya requested review from auxten and xq262144 February 1, 2019 09:54
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 1, 2019

Codecov Report

Merging #247 into develop will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #247      +/-   ##
===========================================
- Coverage    75.94%   75.88%   -0.07%     
===========================================
  Files          159      159              
  Lines        12198    12198              
===========================================
- Hits          9264     9256       -8     
- Misses        2235     2243       +8     
  Partials       699      699

1 similar comment
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 1, 2019

Codecov Report

Merging #247 into develop will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #247      +/-   ##
===========================================
- Coverage    75.94%   75.88%   -0.07%     
===========================================
  Files          159      159              
  Lines        12198    12198              
===========================================
- Hits          9264     9256       -8     
- Misses        2235     2243       +8     
  Partials       699      699

Copy link
Copy Markdown
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@xq262144 xq262144 merged commit b283716 into develop Feb 2, 2019
@laodouya laodouya deleted the feature/unit_client_config branch February 2, 2019 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants