Various bug fixes for new release.#555
Merged
danieltigse merged 1 commit intoCriptext:masterfrom Oct 17, 2019
Merged
Conversation
danieltigse
requested changes
Oct 16, 2019
| fun addCriptextFooter(body: String): String{ | ||
| val watermarkString = "<div></div><br><br>Sent with <a href=\"https://goo.gl/qW4Aks\" " + | ||
| "style=\"color: rgb(0,145,255)\">Criptext</a> secure email" | ||
| val watermarkString = "<div></div><br><br>Sent with <i>Criptext</i> secure email" |
Contributor
There was a problem hiding this comment.
Suggested change
| val watermarkString = "<div></div><br><br>Sent with <i>Criptext</i> secure email" | |
| val watermarkString = "<div></div><br><br><i>Sent with Criptext secure email</i>" |
src/main/res/values-es/strings.xml
Outdated
| <string name="rate_us_message">Si es así, ayúdanos con una calificación. ¡Gracias por tu apoyo!</string> | ||
| <string name="rate_us">Calificar</string> | ||
| <string name="rate_remind_later">Recordar Luego</string> | ||
| <string name="username_is_not_criptext">No es un usuario o dirección de correo de Criptext.</string> |
Contributor
There was a problem hiding this comment.
Suggested change
| <string name="username_is_not_criptext">No es un usuario o dirección de correo de Criptext.</string> | |
| <string name="username_is_not_criptext">El usuario o dirección de correo no pertenece a Criptext.</string> |
| fun `validateEmailAddress should return valid if receives a valid address`() { | ||
| val address = "[email protected]" | ||
| AccountDataValidator.validateEmailAddress(address) `should equal` FormData.Valid(address) | ||
| AccountDataValidator.validateUsername(address) `should equal` FormData.Valid(address) |
Contributor
There was a problem hiding this comment.
I would create another test where validateUsernameOnly fails when an email is passed
f71d7b7 to
61f779c
Compare
61f779c to
5663605
Compare
danieltigse
approved these changes
Oct 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.