Open
Conversation
juliagallucci
approved these changes
Feb 17, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
Good! Minor comment, there's no need to convert the strings to lists before sorting, as sorted() already works on strings directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I completed the anagram checker functions in assignment_1.ipynb.
What did you learn from the changes you have made?
I learned to use if-statements; use functions and methods on lists and strings; create custom functions.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
NA
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I encountered problems with .lower(). If I have string variable x = "ABC" and I call x after running x.lower(), the returned value is still "ABC". Instead, I have to reassign the value to x (i.e. x = x.lower()) in order to get "abc" when I call x. This is what I ended up doing in the assignment even though I thought methods should just update the variable they are applied to without requiring reassignment.
How were these changes tested?
I tested the changes by running the cells that called the anagram checker functions with various inputs.
A reference to a related issue in your repository (if applicable)
NA
Checklist