Open
Conversation
kelichiu
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Point: 30/30
Section 1: ✅
Section 2: ✅
Section 3: ✅
Section 4: ✅
Hi Crystal, thank you for the thoughtful reflection, I enjoyed reading it. Not only your codes are correct, they are also well formatted. Making the codes easy to read is a undermined but essential skill, I'm appreciate your effort. Congrats!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added a logical model inside 02_activities > assignments > images. I also added my answers to Section 1 & 4 of the Assignment1.md file. Lastly, I added requested queries (answering Section 2 & 3) inside assignment1.sql file.
What did you learn from the changes you have made?
I learned how to write queries in SQL using commands like SELECT, JOIN, FROM; filter data using HAVING, WHERE; aggregate data using various aggregate functions like sum, avg.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
No particular challenges. I am still trying to get more familiar with the order of the commands (SELECT > FROM > JOIN > WHERE). Especially with the various filtering, sorting and ordering functions, I'm still not quite clear how they should be ordered.
How were these changes tested?
I ran the queries in DB Browser to make sure the resulting output matched the descriptions.
A reference to a related issue in your repository (if applicable)
NA
Checklist