Merged
Conversation
- removed main.rs (middleware is library) - added small documentation for middleware (features of middleware) - added configuration for server - added configuration for auth server - added documents for configuration - added example for using `Config` and `AuthServer` - added function to make `rustls::ServerConfig` (todo) - reformatted Cargo.toml and added `include` part of `package` in Cargo.toml - will be using tokio + rustls for connection in connection Since there was no actual code running, no test was written.
- changed comments to doc comments - removed `make_tls_config` function - changed `rustls::ServerConfig` to `key_path` and `cert_path` - removed `custom_debug_derive` dependency - added `serde` dependency - changed example in document
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 33.33% 38.46% +5.12%
==========================================
Files 3 4 +1
Lines 9 26 +17
Branches 0 11 +11
==========================================
+ Hits 3 10 +7
- Misses 6 16 +10 |
sboh1214
approved these changes
Aug 27, 2021
Collaborator
sboh1214
left a comment
There was a problem hiding this comment.
I modified the title to start with a simple present verb and have more information.
utilForever
approved these changes
Aug 29, 2021
Member
utilForever
left a comment
There was a problem hiding this comment.
Next time, you should add some blank lines to improve readability. 📓
Collaborator
|
I suggest to change a small things. - //! .auth_config(AuthServer::builder().password("password").build().unwrap())
+ //! .auth_config(AuthServer::builder().password("<your password>").build().unwrap())at the middleware/src/config.rs line 13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigandAuthServerrustls::ServerConfig(todo)includepart ofpackageinCargo.toml
make_tls_configfunctionrustls::ServerConfigtokey_pathandcert_pathcustom_debug_derivedependencyserdedependencySince there was no actual code running, no test was written.