Skip to content

Update siren.lua#30

Merged
lethosor merged 1 commit intoDFHack:masterfrom
OwnageIsMagic:patch-2
Nov 23, 2017
Merged

Update siren.lua#30
lethosor merged 1 commit intoDFHack:masterfrom
OwnageIsMagic:patch-2

Conversation

@OwnageIsMagic
Copy link
Copy Markdown
Contributor

@OwnageIsMagic OwnageIsMagic commented Aug 20, 2017

flags now bitfield and docs says that I can simply assign a lua table for that
Will it call default constructor or something similar?
Or I should set every field in it?

offtopic:
xml says there only 4 fields but pairs iterate up to 31
can I safely use last bits in bitfiels for my own purposes?

@lethosor
Copy link
Copy Markdown
Member

Thanks! I think flags probably got changed to an actual bitfield in the XML at some point, which broke this.

You can probably use flags for your own purposes, until DF starts using them (probably unlikely, but be careful).

@OwnageIsMagic
Copy link
Copy Markdown
Contributor Author

Does dfhack have any policies on setting unk* values?
looks like empty table just create <uint32_t>0 as value, is it right?

@lethosor lethosor merged commit 09cf8dd into DFHack:master Nov 23, 2017
@lethosor
Copy link
Copy Markdown
Member

0 should be right. Not sure what you were asking about unk fields. You can use them, although suggesting names for them is better.

@OwnageIsMagic OwnageIsMagic deleted the patch-2 branch November 23, 2017 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants