export-dt-ini: name offset update#47
Merged
lethosor merged 1 commit intoDFHack:masterfrom Feb 16, 2018
Merged
Conversation
Use name offsets from language_name instead of unit, since it is no longer at the beginning of the structure (because unit became a class type).
lethosor
approved these changes
Feb 16, 2018
|
|
||
| header('dwarf_offsets') | ||
| address('first_name',df.unit,'name','first_name') | ||
| address('nick_name',df.unit,'name','nickname') |
Member
There was a problem hiding this comment.
This wasn't taking the vtable pointer into account? Weird.
Contributor
Author
There was a problem hiding this comment.
DT was using these offsets in other case than unit.name (e.g. identity). It used to work because it was at the beginning so it was the same as language_name offsets. Because of the added vtable pointer, it is not any more, and it required breaking changes in DT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use name offsets from language_name instead of unit, since it is no longer at the
beginning of the structure (because unit became a class type).
Sorry, I forgot to send you that change. It is required from DT 39.2 and incompatible with older versions.