Merged
Conversation
Contributor
There was a problem hiding this comment.
오
find-minimum-in-rotated-sorted-array 문제를 통해 만든
min 값 찾는 로직을 사용해서 푸셨군요
search-in-rotated-sorted-array/dev-jonghoonpark.md
저는 그냥 아예 새로 작성했는데 논리가 분리되는 면에서는 작성해주신 코드도 재밌네요 ㅎㅎ
Contributor
Author
There was a problem hiding this comment.
@dev-jonghoonpark
오 이렇게 풀 수도 있군요.. 빠르기도 하고 함수도 덜 사용하여 좋은 풀이법 같습니다! 공유해주셔서 감사합니다!
DaleSeo
approved these changes
Jun 9, 2024
leokim0922
reviewed
Jun 9, 2024
| int max = 0; | ||
| while (left < right) { | ||
| int area = (right - left) * Math.min(height[left], height[right]); | ||
| if (area > max) { |
Contributor
There was a problem hiding this comment.
요 부분을
max = Math.max(max, area)요렇게 고치는걷 괜찮아 보이네요!
Contributor
Author
There was a problem hiding this comment.
네네 그렇네요 한 줄 줄이는 것도 가독성 측면에서 좋은 것 같습니다 의견 감사합니다!
Invidam
approved these changes
Jun 9, 2024
Contributor
Invidam
left a comment
There was a problem hiding this comment.
코드 깔끔하게 작성해주시는 게 대단하네요! 이번주도 수고하셨습니다 👍
bky373
commented
Jun 9, 2024
Contributor
Author
There was a problem hiding this comment.
이 문제는 지독히 안 풀리는 문제 중 하나네요.. ㅠㅠ 역시 세상엔 고수가 많은 것 같습니다
leokim0922
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problems